Forráskód Böngészése

Add prosepector profile and quality clean up

Bryon Bailey 4 éve
szülő
commit
99038d5db0
3 módosított fájl, 18 hozzáadás és 12 törlés
  1. 6 0
      .prospector.yaml
  2. 10 10
      modules/tle_database.py
  3. 2 2
      tle_fetcher.py

+ 6 - 0
.prospector.yaml

@@ -0,0 +1,6 @@
+strictness: high
+
+pylint:
+  enable:
+    - trailing-whitespace
+    - missing-finale-newline

+ 10 - 10
modules/tle_database.py

@@ -1,6 +1,6 @@
-import mariadb
-import logging
 import sys
+import logging
+import mariadb
 
 logger = logging.getLogger("tle_fetcher." + __name__)
 
@@ -19,8 +19,8 @@ class TleDatabase:
                 port=3306,
                 database="celestrak_tles",
             )
-        except mariadb.Error as e:
-            logger.error("Error connecting to MariaDB Platform: %s", e.msg)
+        except mariadb.Error as err:
+            logger.error("Error connecting to MariaDB Platform: %s", err.msg)
             sys.exit(1)
 
         self.conn = conn
@@ -31,8 +31,8 @@ class TleDatabase:
         try:
             cur.execute("delete from sat_groups")
             cur.execute("delete from tles")
-        except mariadb.Error as e:
-            logger.error("Error clearing tables: %s", e.msg)
+        except mariadb.Error as err:
+            logger.error("Error clearing tables: %s", err.msg)
         self.conn.commit()
 
     def update_tles(self, tles: list):
@@ -42,8 +42,8 @@ class TleDatabase:
             cur.executemany(
                 "insert into tles (sat, sat_cat_num, tle) values (?,?,?)", tles
             )
-        except mariadb.Error as e:
-            logger.error("Error updating TLEs: %s", e.msg)
+        except mariadb.Error as err:
+            logger.error("Error updating TLEs: %s", err.msg)
         self.conn.commit()
 
     def update_sat_group(self, group: list):
@@ -54,8 +54,8 @@ class TleDatabase:
                 "insert ignore into sat_groups (sat_cat_num, group_name) values (?,?)",
                 group,
             )
-        except mariadb.Error as e:
-            logger.error("Error updating groups: %s", e.msg)
+        except mariadb.Error as err:
+            logger.error("Error updating groups: %s", err.msg)
         self.conn.commit()
 
     def close_db(self):

+ 2 - 2
tle_fetcher.py

@@ -66,8 +66,8 @@ def main(tle_rd: TleReader, tle_db: TleDatabase) -> None:
     tle_db.update_tles(tles)
 
     for group in groups:
-        gp = tle_rd.get_group(group)
-        tle_db.update_sat_group(gp)
+        grp = tle_rd.get_group(group)
+        tle_db.update_sat_group(grp)
 
     tle_db.close_db()